Set empty program name to hash of instructions #3493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 24, 2024 12:28
This puts hash.cpp/hash.h in a more central location for use by other project files.
ebpf_program_load_bytes now hashes the instructions and uses that for the name instead of generating a random number. Closes microsoft#3443
mikeagun
requested review from
dthaler,
poornagmsft,
Alan-Jowett,
saxena-anurag,
shankarseal,
dv-msft,
gtrevi,
shpalani,
matthewige,
mtfriesen and
rectified95
as code owners
mikeagun
changed the title
|
Sorting out signed/unsigned mismatch this caused to make build fail. |
dthaler
reviewed
May 25, 2024
| REQUIRE(program_info.nr_map_ids == 0); | ||
| REQUIRE(program_info.map_ids == 0); | ||
| REQUIRE(program_info.name != NULL); | ||
| // Name should contain SHA256 hash in hex (minus last char to stay under BPF_OBJ_NAME_LEN) |
There was a problem hiding this comment.
Suggested change
| // Name should contain SHA256 hash in hex (minus last char to stay under BPF_OBJ_NAME_LEN) | |
| // Name should contain SHA256 hash in hex (minus last char to stay under BPF_OBJ_NAME_LEN). |
| @@ -1,10 +1,10 @@ | |||
| // Copyright (c) eBPF for Windows contributors | |||
| // SPDX-License-Identifier: MIT | |||
|
|
|||
| #include "../../libs/shared/hash.h" | |||
There was a problem hiding this comment.
Rather than putting the path here, it's better to put it in the include path in the vcxproj file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #3443 by using the SHA256 hash of the program instructions as the program name instead of using
rand()to generate the name.Instruction lists are now given a unique name (fixing the issue), and this solution avoids any potential problems from changing the
rand()state for the process. Only the first 63 characters of the hash are used to keep under bpf object length limit (64).As part of this change, hash.cpp and hash.h were moved from tests/libs/util to libs/shared so they are in a more central location for use in other project files.
Testing
Adds ebpf_program_load_bytes-name-gen test case in end_to_end.cpp
Documentation
N/A
Installation
N/A