Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add disk usage widget #973

Closed
wants to merge 2 commits into from
Closed

Conversation

zanseb
Copy link

@zanseb zanseb commented May 31, 2023

Summary of the pull request

I noticed that there is no widget for disk usage, so I tried to add one.

image

References and relevant issues

#1085

@zanseb
Copy link
Author

zanseb commented May 31, 2023

This widget is still a WIP. The missing points are:

  • Widget Icon
  • "Next Disk" Implementation

Let me know if this PR is welcome at the current stage of the project, otherwise feel free to close it :)

@MeikTranel
Copy link

Nothing but love for this PR but i feel like the whole Next Disk thing akin to the Next GPU looks hideous and is almost never what i want to click on a widget - i'd want to select the disk beforehand and then only change it using a configuration dialog of some sort - @cinnamon-msft is this just a temporary thing until a more fleshed out interface for widget configuration was designed or is this intentional? Ideally i'd like this to be configured in this dialog:
image

@niels9001
Copy link
Contributor

niels9001 commented May 31, 2023

Nothing but love for this PR but i feel like the whole Next Disk thing akin to the Next GPU looks hideous and is almost never what i want to click on a widget - i'd want to select the disk beforehand and then only change it using a configuration dialog of some sort - @cinnamon-msft is this just a temporary thing until a more fleshed out interface for widget configuration was designed or is this intentional? Ideally i'd like this to be configured in this dialog: image

Yeah see your point.. Something like a PipsPager would look better but not sure if widgets support that. I guess not?

@zanseb
Copy link
Author

zanseb commented May 31, 2023

Would it be possible to preview all possible instances of a resource, so that the user has the possibility to pin a specific instance?

E.g.
My PC has two drives C: and D:. When adding a widget, I see the preview of both drives and can add a specific instance or both instances of the widget.

Copy link

@okineadev okineadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excelent!

@crutkas
Copy link
Member

crutkas commented Jun 6, 2023

if this is a WIP, mind if i shift this to a draft?

@zanseb zanseb marked this pull request as draft June 7, 2023 09:21
@crutkas crutkas mentioned this pull request Jun 7, 2023
@EdwinVD
Copy link

EdwinVD commented Sep 17, 2023

@zanseb I've already created a Windows 11 widget called 'Hard Disk' that displays all the disks and network storage in a progress bar. In addition, there's another widget that shows different types of files with a colored progress bar. These widgets are available on the Microsoft Store.

Take a look!

Microsoft Store - Hard Disk:
https://apps.microsoft.com/store/detail/hard-disk/9NNCSN19QMCX?hl=en-us

@bbonaby
Copy link
Contributor

bbonaby commented Sep 27, 2023

@EricJohnson327 @krschau, and @crutkas / @cinnamon-msft do we still want this? If so, I can start a review.

@krschau
Copy link
Contributor

krschau commented Jun 7, 2024

Closing this after a long period of inactivity to clean up the repo a little bit. Happy to reopen if this PR is revisited!

@krschau krschau closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants