Fix event tags for a couple of the methods provided by the Telemetry class

[adrastogi]

Summary of the pull request

The tags are missing from the Exception (and TimeTaken) logging helper methods in the Telemetry class. This change includes those entries in the data payload.

References and relevant issues

Detailed description of the pull request / Additional comments

I was looking through the class and noticed this, so I made the surgical fix for it. Theoretically, these events should be rewritten to follow the format we are trying to use for events now (e.g., as separate classes); that was a more involved change than I had time for due in part to the Exception class's use of additional internal methods... I figured that this is still a step in the right direction.

Validation steps performed

PR checklist

• Closes #xxx
• Tests added/passed
• Documentation updated

[dhoehna]

The Priv A tags might change depending on when the telemetry was fired. I suggest to have Priv_A tags as an input parameter.

Further, ProductAndServiceUsage should not be used when we, the developers, can't trace the event to a specific user action.

An Event name should also be added as an input parameter.

[adrastogi]

Spot on regarding the second point- these should be ProductAndServicePerformance, which I've fixed.

For the first point, my thought was that as these are related to durations and errors, the tags should be hard-coded... maybe I'm not imagining a scenario where a caller would want to override these.

For the third point, I guess the way this event is designed, all exception events are aggregated together, and rely on the action for bucketing- this seems ok to me, but let me know if you feel strongly about that.

---

In reply to: 2066638154

[dhoehna]

durations and errors,
I believe I understand your point of view. If an error occurs, most likely, we developers made a mistake.

I took a dive into the telemetry code and found LogError. LogError uses ProductAndServicePerformance.

If the DAS team hasn't said anything, I'm okay with the tag as ProductAndServicePerformance.