Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SSH widget to show entries with multiple Host aliases #2664

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

Gohellp
Copy link
Contributor

@Gohellp Gohellp commented Apr 17, 2024

Summary of the pull request

Changes to Regexp to support writing from multiple Host aliases

References and relevant issues

#2646

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

@krschau
Copy link
Contributor

krschau commented Apr 18, 2024

As part of this, it would be great if you could update our sample config (https://github.com/microsoft/devhome/blob/main/extensions/CoreWidgetProvider/Widgets/Assets/example_config) to include the kind of host you're fixing this for.

@Gohellp
Copy link
Contributor Author

Gohellp commented Apr 18, 2024

@microsoft-github-policy-service agree

@krschau
Copy link
Contributor

krschau commented Jun 3, 2024

Adding "do-not-merge" while I check something on our end.

@krschau krschau added Do-Not-Merge Don't merge this in yet and removed Do-Not-Merge Don't merge this in yet labels Jun 3, 2024
@krschau krschau changed the title fix issue microsoft/devhome#2646 Allow SSH widget to show entries with multiple Host aliases Jun 7, 2024
@EricJohnson327
Copy link
Contributor

Closing and reopening to try to trigger builds.

@EricJohnson327 EricJohnson327 reopened this Jun 7, 2024
@krschau krschau merged commit 71c6700 into microsoft:main Jun 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSH widget does not show hosts with multi-word alias names
4 participants