Sort and pagination. #2286
Draft
Sort and pagination. #2286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
February 14, 2024 12:37
dhoehna
requested review from
vineeththomasalex,
dkbennett,
krschau,
EricJohnson327,
brialmsft,
SohamDas2021,
AmelBawa-msft,
bbonaby and
a team
added 2 commits
February 20, 2024 12:06
krschau
approved these changes
Feb 20, 2024
tools/SetupFlow/DevHome.SetupFlow/ViewModels/AddRepoViewModel.cs
Outdated
Show resolved
Hide resolved
tools/SetupFlow/DevHome.SetupFlow/ViewModels/AddRepoViewModel.cs
Outdated
Show resolved
Hide resolved
tools/SetupFlow/DevHome.SetupFlow/ViewModels/AddRepoViewModel.cs
Outdated
Show resolved
Hide resolved
tools/SetupFlow/DevHome.SetupFlow/ViewModels/IncrementalRepoViewItemViewModel.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com>
Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com>
Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com>
…tps://github.com/microsoft/devhome into user/dhoehna/ImproveSearchingSortingAndFiltering
|
Review needed for Combo Box, not designed by design |
tools/SetupFlow/DevHome.SetupFlow/ViewModels/IncrementalRepoViewItemViewModel.cs
Show resolved
Hide resolved
vineeththomasalex
approved these changes
Feb 22, 2024
|
Converting to draft until design signs off on the UI change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Adding the ability to sort repo results by name.
Added pagination in the repo window.
References and relevant issues
Detailed description of the pull request / Additional comments
In addition to the above fixes, I also moved more code out of the View's code-behind and into
AddRepoViewModel.The code in
AddRepoViewModelis a bit messier and it still has a reference back toAddRepoDialogHowever, this is a necessary step to get as much code out ofAddRepoDialog.xaml.csas possible.These improvement changes are now in #2298 Please use that PR if you want to comment on any non-sort and pagination items.
Validation steps performed
Cloned repos and made a dev drive.
PR checklist
Movie! (The ListView, and page size was altered for this video to show off pagination)
