Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the assistant test case error caused by openai incompatible change #2718

Merged
merged 2 commits into from
May 22, 2024

Conversation

IANTHEREAL
Copy link
Collaborator

Why are these changes needed?

OpenAI Assistant Service make some incompatible changes, it would cause failing to create assistant, if the function name is not unique. One case scene: https://github.com/microsoft/autogen/actions/runs/9074961126/job/24934934702?pr=2672

Because there was a problem with my openai account, I did not conduct a comprehensive test, but I passed the two failed cases. Hope this pr can fix the case failure.

Checks

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 25.29%. Comparing base (19de99e) to head (6cb2207).

Files Patch % Lines
autogen/agentchat/contrib/gpt_assistant_agent.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2718      +/-   ##
==========================================
- Coverage   34.36%   25.29%   -9.07%     
==========================================
  Files          87       93       +6     
  Lines        9336     9420      +84     
  Branches     1987     2142     +155     
==========================================
- Hits         3208     2383     -825     
- Misses       5862     6763     +901     
- Partials      266      274       +8     
Flag Coverage Δ
unittest 12.70% <0.00%> (?)
unittests 24.52% <0.00%> (-9.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekzhu ekzhu added this pull request to the merge queue May 22, 2024
Merged via the queue into microsoft:main with commit b698a98 May 22, 2024
76 of 90 checks passed
@IANTHEREAL IANTHEREAL deleted the oai_test_fix branch May 23, 2024 14:08
jayralencar pushed a commit to jayralencar/autogen that referenced this pull request May 28, 2024
Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants