Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add silent option in nested chats and group chat #2712

Merged
merged 4 commits into from
May 22, 2024

Conversation

robraux
Copy link
Collaborator

@robraux robraux commented May 17, 2024

Why are these changes needed?

The silent parameter is useful when dealing with deeply orchestrated workflows on the CLI. This adds additional support for respecting this useful configuration in the more complex orchestrators.

  • Adds silent option to GroupChatManager to mirror other silent configurations in Agents
  • Respects silent request in Nested Chats to removed otherwise to avoidable __post_carryover_processing messaging.

Decisions

  • Deliberately leaves introductions and broadcast replies as silent=True as these add no value to display.
  • GroupChat silent configuration tweaked to support the plugin use case without adding additional vars to ConversableAgent.

Related issue number

Replaces PR: #2212
Closes: #1335

Checks

@robraux
Copy link
Collaborator Author

robraux commented May 17, 2024

@robraux please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@robraux robraux changed the title feat: respect silent request in nested chats and group chat Add silent option in nested chats and group chat May 17, 2024
@robraux robraux requested a review from ekzhu May 22, 2024 00:54
@sonichi sonichi added this pull request to the merge queue May 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 22, 2024
@ekzhu ekzhu enabled auto-merge May 22, 2024 17:33
@ekzhu ekzhu added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit fb74624 May 22, 2024
78 of 93 checks passed
@ekzhu ekzhu deleted the silence-groupchat-nestedchat branch May 22, 2024 17:46
jayralencar pushed a commit to jayralencar/autogen that referenced this pull request May 28, 2024
* feat: respect silent request in nested chats and group chat

* fix: address plugin test

---------

Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: allow silent=True while initiating a group chat
3 participants