Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: allow silent=True while initiating a group chat #1335

Closed
ari9dam opened this issue Jan 19, 2024 · 5 comments · Fixed by #2712
Closed

[Feature Request]: allow silent=True while initiating a group chat #1335

ari9dam opened this issue Jan 19, 2024 · 5 comments · Fixed by #2712
Labels
enhancement New feature or request good first issue Good for newcomers group chat group-chat-related issues

Comments

@ari9dam
Copy link

ari9dam commented Jan 19, 2024

Is your feature request related to a problem? Please describe.

group_chat always print to console, there is no way to prevent the print

Describe the solution you'd like

allow silent=True in initiate_chat()

Additional context

No response

@ari9dam ari9dam added the enhancement New feature or request label Jan 19, 2024
@sonichi sonichi added the group chat group-chat-related issues label Jan 19, 2024
@ekzhu ekzhu added the good first issue Good for newcomers label Jan 19, 2024
@ekzhu
Copy link
Collaborator

ekzhu commented Jan 19, 2024

I think the solution is quite simple: add a silent argument to the GroupChatManager class. I think the only place that prints out to the console is in:
https://github.com/microsoft/autogen/blob/main/autogen/agentchat/groupchat.py#L388
and
https://github.com/microsoft/autogen/blob/main/autogen/agentchat/groupchat.py#L437

@cliff-4
Copy link

cliff-4 commented Feb 16, 2024

@ekzhu Can you please specify how exactly one should add the silent argument?

I tried adding a silent=True parameter when initiating the GroupChatManager class, but I got a TypeError that silent is not a valid input for a ConversableAgent (since the parameter is passed on to this class). Thanks for your help!

@ekzhu
Copy link
Collaborator

ekzhu commented Feb 17, 2024

I think in this case silent should be GroupChatManager's own argument, as ConversableAgent doesn't have this argument.

@sonichi
Copy link
Collaborator

sonichi commented Feb 17, 2024

silent is a parameter of send

@jtoy
Copy link
Collaborator

jtoy commented Mar 30, 2024

I have a PR, but its not working properly. I gave GroupChatManager a silent option and I pass it to send, but the messages are never silenced. Can I get some feedback on this:
#2212 @sonichi @ekzhu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers group chat group-chat-related issues
Projects
None yet
5 participants