fix55816: exclude files with re-exports if excluded by preferences.autoImportFileExcludePatterns #58537
Conversation
typescript-bot
added
the
For Milestone Bug
Is that the right issue? It seems unrelated. |
|
It is the correct issue, see the call stack here. The quick fix is not offered because getting autoimports fails when the file is excluded in preferences |
| if (skipAlias(info[0].symbol, getChecker(info[0].isFromPackageJson)) === symbol && info.some(i => i.moduleSymbol === moduleSymbol || i.symbol.parent === moduleSymbol)) { | ||
| if ( | ||
| skipAlias(info[0].symbol, getChecker(info[0].isFromPackageJson)) === symbol | ||
| && info.some(i => moduleSymbolExcluded || i.moduleSymbol === moduleSymbol || i.symbol.parent === moduleSymbol) |
There was a problem hiding this comment.
Plot twist: all existing tests pass if you delete this entire info.some(...) part of the condition. That might be all that’s needed to fix the bug?
There was a problem hiding this comment.
I tried that and wasn't sure if that was the best fix, since I tracked it back to here, where it looked like it was intentionally added. :D if your opinion is that the check was unnecessary, I'll change it back to just deleting this extra check
There was a problem hiding this comment.
Actually, I remember something did break when I tried that-- tests/cases/fourslash/server/autoImportReExportFromAmbientModule.ts breaks with the info.some call removed. Since exporting ambient modules doesn't use filenames, I figured it would be alright to skip the check for ignored files
There was a problem hiding this comment.
| && info.some(i => moduleSymbolExcluded || i.moduleSymbol === moduleSymbol || i.symbol.parent === moduleSymbol) | |
| && (moduleSymbolExcluded || info.some(i => i.moduleSymbol === moduleSymbol || i.symbol.parent === moduleSymbol)) |
| if (skipAlias(info[0].symbol, getChecker(info[0].isFromPackageJson)) === symbol && info.some(i => i.moduleSymbol === moduleSymbol || i.symbol.parent === moduleSymbol)) { | ||
| if ( | ||
| skipAlias(info[0].symbol, getChecker(info[0].isFromPackageJson)) === symbol | ||
| && info.some(i => moduleSymbolExcluded || i.moduleSymbol === moduleSymbol || i.symbol.parent === moduleSymbol) |
There was a problem hiding this comment.
| && info.some(i => moduleSymbolExcluded || i.moduleSymbol === moduleSymbol || i.symbol.parent === moduleSymbol) | |
| && (moduleSymbolExcluded || info.some(i => i.moduleSymbol === moduleSymbol || i.symbol.parent === moduleSymbol)) |
Fixes #55816
This failure happened when a file
foo.tsthat re-exports some variableTis ignored by"typescript.preferences.autoImportFileExcludePatterns".foo.tswas properly ignored byexportMap, but the autoImports still attempted to generate the import withfoo.tsinstead of the file that originally exportedT, which lead to a failure.This PR allows the
moduleSymbolfound by autoImports to not match themoduleSymbolfound byexportInfoMapif the moduleSymbol found by autoimports is excluded.