-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hosts] Improve Resizing behavior #32788
Conversation
@davidegiacometti |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @htcfreek
Thanks for looking into this!
This PR reminded me #28483
The idea was to get rid of the fixed width of the address column using the DataTable from the CommunityToolkit Labs package. I gave a try in the past but the control wasn't mature enough to be used (don't know what's the current state).
Don't like the IPv6 being wrapped but I think this is an improvement.
@davidegiacometti |
@davidegiacometti The windows shows in the default open size and is not resized. |
Looks better! I will test and review the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for the contribution!
@jaimecbernardo |
Summary of the Pull Request
The old ui definition causes the host names column to hid. Now it is not hiding anymore and the Address column has a smaller min width.
Resizing
Before:
After:
Alignment on small window with correct resizing behavior
Before:
After:
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Manual tests.