Launch/Open/GoTo: Code #32516
Launch/Open/GoTo: Code #32516
Conversation
Jay-o-Way
force-pushed
the
launch-open-go-code
branch
from
9e1cba0
to
8197608
Compare
There was a problem hiding this comment.
Thanks for opening the PR.
I see the PR will contain changes that seem to be changing localization ids, retriggering the localization for all these strings.
It also changes names of telemetry events, which means it'll cause confusion in the names of events received and they'll be treated like two different events across versions.
I paused my review, since the PR seems to have many of these. These are not visible for the user, so can we please not make these changes as they'll cause more work / confusion for changes that won't affect the user in any way?
| /// <summary> | ||
| /// Invoked when the application is launched. | ||
| /// </summary> | ||
| /// <param name="args">Details about the launch request and process.</param> | ||
| protected override void OnLaunched(LaunchActivatedEventArgs args) |
There was a problem hiding this comment.
Why are we deleting these comments? 🤔
There was a problem hiding this comment.
Uhm, I have forgotten now. But I would guess that this comment is so obvious?
| @@ -183,17 +183,17 @@ | |||
| <data name="Setting_Description_RestoreSize" xml:space="preserve"> | |||
| <value>Restore the original size of windows when unsnapping</value> | |||
| </data> | |||
| <data name="Setting_Launch_Editor_Label" xml:space="preserve"> | |||
There was a problem hiding this comment.
These are internal labels which will retrigger localization. I don't think it's worth retriggering localization for all these strings just to change internal names.
There was a problem hiding this comment.
Hm, I see the point. So: revert all resw/rex files, right?
There was a problem hiding this comment.
LOL this entire file seems to be obsolete
@SeraphimaZykova can you confirm?
| @@ -16,7 +16,7 @@ | |||
| #define EventEnableFancyZonesKey "FancyZones_EnableFancyZones" | |||
| #define EventKeyDownKey "FancyZones_OnKeyDown" | |||
| #define EventZoneSettingsChangedKey "FancyZones_ZoneSettingsChanged" | |||
| #define EventEditorLaunchKey "FancyZones_EditorLaunch" | |||
| #define EventEditorOpenKey "FancyZones_EditorOpen" | |||
There was a problem hiding this comment.
This will make old events not match new ones. It doesn't seem to make sense.
There was a problem hiding this comment.
I see. I'm not familiar with telemetry. So: revert any/all trace.cpp and trace.h files, right?
| @@ -27,10 +27,10 @@ public OobeRegistryPreview() | |||
|
|
|||
| private void Launch_RegistryPreview_Click(object sender, Microsoft.UI.Xaml.RoutedEventArgs e) | |||
| { | |||
| ShellPage.SendDefaultIPCMessage("{\"action\":{\"RegistryPreview\":{\"action_name\":\"Launch\", \"value\":\"\"}}}"); | |||
| ShellPage.SendDefaultIPCMessage("{\"action\":{\"RegistryPreview\":{\"action_name\":\"Open\", \"value\":\"\"}}}"); | |||
There was a problem hiding this comment.
@jaimecbernardo I wonder if this will be a "breaking change" too?
| @@ -183,17 +183,17 @@ | |||
| <data name="Setting_Description_RestoreSize" xml:space="preserve"> | |||
| <value>Restore the original size of windows when unsnapping</value> | |||
| </data> | |||
| <data name="Setting_Launch_Editor_Label" xml:space="preserve"> | |||
There was a problem hiding this comment.
Hm, I see the point. So: revert all resw/rex files, right?
| @@ -16,7 +16,7 @@ | |||
| #define EventEnableFancyZonesKey "FancyZones_EnableFancyZones" | |||
| #define EventKeyDownKey "FancyZones_OnKeyDown" | |||
| #define EventZoneSettingsChangedKey "FancyZones_ZoneSettingsChanged" | |||
| #define EventEditorLaunchKey "FancyZones_EditorLaunch" | |||
| #define EventEditorOpenKey "FancyZones_EditorOpen" | |||
There was a problem hiding this comment.
I see. I'm not familiar with telemetry. So: revert any/all trace.cpp and trace.h files, right?
Jay-o-Way
force-pushed
the
launch-open-go-code
branch
from
5f4a324
to
ba51ea1
Compare
Summary of the Pull Request
Split from #32351
Closely linked to #32514 and #32519.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Build