-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better support for PA with empty mesh partitions #4260
Open
pazner
wants to merge
16
commits into
master
Choose a base branch
from
pa-empty-partitions
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Apr 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 966143b - Browse repository at this point
Copy the full SHA 966143bView commit details -
Configuration menu - View commit details
-
Copy full SHA for aab7352 - Browse repository at this point
Copy the full SHA aab7352View commit details -
Configuration menu - View commit details
-
Copy full SHA for a981a24 - Browse repository at this point
Copy the full SHA a981a24View commit details -
Configuration menu - View commit details
-
Copy full SHA for d3855ad - Browse repository at this point
Copy the full SHA d3855adView commit details -
Replace many instances of GetFE(0) with GetTypicalFE()
Also replace many instances of GetElementTransformation(0) with GetTypicalElementTransformation() and instances of GetElementGeometry(0) with GetTypicalElementGeometry(). Remove some "early returns" in PA code with empty partitions. The reasoning is that the early returns create divergent code paths among different MPI ranks, which can cause deadlocks if e.g. collectives are used in code paths on not all ranks.
Configuration menu - View commit details
-
Copy full SHA for ef9043a - Browse repository at this point
Copy the full SHA ef9043aView commit details -
Add Mesh::GetTypicalFaceGeometry
Analogous to Mesh::GetTypicalElementGeometry
Configuration menu - View commit details
-
Copy full SHA for 54f6694 - Browse repository at this point
Copy the full SHA 54f6694View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8184de5 - Browse repository at this point
Copy the full SHA 8184de5View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec53569 - Browse repository at this point
Copy the full SHA ec53569View commit details -
Configuration menu - View commit details
-
Copy full SHA for a7eed94 - Browse repository at this point
Copy the full SHA a7eed94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4af8539 - Browse repository at this point
Copy the full SHA 4af8539View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9aba232 - Browse repository at this point
Copy the full SHA 9aba232View commit details
Commits on May 1, 2024
-
Add FiniteElementCollection::GetTraceFE
This is a variable-order version of TraceFiniteElementForGeometry, analogous to FiniteElementCollection::GetFE, which is a variable-order version of FiniteElementForGeometry.
Configuration menu - View commit details
-
Copy full SHA for c768c5f - Browse repository at this point
Copy the full SHA c768c5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b6c6ce - Browse repository at this point
Copy the full SHA 3b6c6ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for ccccdf1 - Browse repository at this point
Copy the full SHA ccccdf1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63f977d - Browse repository at this point
Copy the full SHA 63f977dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d866132 - Browse repository at this point
Copy the full SHA d866132View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.