-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eikonal solver for MFEM #4248
Eikonal solver for MFEM #4248
Conversation
This is now ready for review |
Co-authored-by: Dohyun Kim <dhkim.cse@gmail.com>
Co-authored-by: Dohyun Kim <dhkim.cse@gmail.com>
Co-authored-by: Dohyun Kim <dhkim.cse@gmail.com>
Thank you for the comments, @dohyun-cse! With help from @psocratis, I think I could implement all of them. Please take a look to see if I missed anything |
@bslazarov and @psocratis, can you please review? |
This is a really cool example, thanks @brendankeith! Can you also
|
Co-authored-by: Socratis Petrides <petrides1@llnl.gov>
Co-authored-by: Socratis Petrides <petrides1@llnl.gov>
Thanks! I will prioritize the web PR once this PR gets two approvals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great example, thanks @brendankeith !
Merged in |
Thanks for reviewing my PR, @vladotomov, @dohyun-cse, @psocratis, and @tzanio !! |
This PR presents a new high-order solver for the eikonal equation,
$$|\nabla u | = 1 ~\text{ in } \Omega, \quad u = 0 ~\text{ on }\partial \Omega.$$
The proximal Galerkin method used to solve this problem is based on ongoing research with Surowiec, Farrell, and Dokken.
PR Checklist
make style
.CHANGELOG
:CHANGELOG
to group with other related features?INSTALL
:make
orcmake
have a new target?.github
.appveyor.yml
.gitignore
:make distclean; git status
shows any files that were generated from the source by the project (not an IDE) but we don't want to track in the repository.examples/makefile
:SEQ_EXAMPLES
andPAR_EXAMPLES
variables.clean
target..gitignore
file.examples/CMakeLists.txt
:ALL_EXE_SRCS
variable.THIS_TEST_OPTIONS
is set correctly for the new example.doc/CodeDocumentation.dox
.examples/pumi
), list it indoc/CodeDocumentation.conf.in
src/examples.md
.src/examples.md
andsrc/img
.examples.md
, list the example under the appropriate categories, add new categories if necessary.features.md
.makefile
andmakefile
in corresponding miniapp directory..gitignore
file.CMakeLists.txt
file in theminiapps
directory, if the new miniapp is in a new directory.CMakeLists.txt
file in the new miniapp directory.doc/CodeDocumentation.dox
miniapps/nurbs
), add it toMINIAPP_SUBDIRS
in themakefile
.miniapps/nurbs
), list it indoc/CodeDocumentation.conf.in
src/meshing.md
andsrc/electromagnetics.md
files.src/examples.md
andsrc/img
.features.md
.mfem/web
repo.README
(rare).doc/CodeDocumentation.dox
(rare).make unittest
to make sure all unit tests pass.tests/scripts
.