-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Managed Umpire memory space #4229
base: master
Are you sure you want to change the base?
Conversation
…umpire memory space cleanup
Can't you just set the desired Umpire allocators with |
This is for MI300, we need something that uses a single buffer/isn't going to memcpy, just sync when we need to use the buffer on the host, and the managed type seemed like the right approach. We could augment the Umpire host/device types so they optional don't copy and so the device type optional doesn't actually allocate but that seemed more complex. Thoughts?
We always did the CUDA/HIP calls, I just cleaned up the preprocessor defines a little, but yes, the Umpire memcpy only works with Umpire allocated pointers on both sides and since we don't use Umpire for host memory we're out of luck ! |
@tomstitt, do we need to expedite this for the mfem-4.7 release? |
I'm not convinced this is the right approach. I think we should have a meeting to discuss this. |
No, that's okay, thanks tho! |
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch. |
Adds managed Umpire host and device memory spaces (
ManagedUmpireHostMemorySpace
+ManagedUmpireDeviceMemorySpace
) and factors out some common stuff to the base classPR Checklist
make style
.CHANGELOG
:CHANGELOG
to group with other related features?INSTALL
:make
orcmake
have a new target?.github
.appveyor.yml
.gitignore
:make distclean; git status
shows any files that were generated from the source by the project (not an IDE) but we don't want to track in the repository.examples/makefile
:SEQ_EXAMPLES
andPAR_EXAMPLES
variables.clean
target..gitignore
file.examples/CMakeLists.txt
:ALL_EXE_SRCS
variable.THIS_TEST_OPTIONS
is set correctly for the new example.doc/CodeDocumentation.dox
.examples/pumi
), list it indoc/CodeDocumentation.conf.in
src/examples.md
.src/examples.md
andsrc/img
.examples.md
, list the example under the appropriate categories, add new categories if necessary.features.md
.makefile
andmakefile
in corresponding miniapp directory..gitignore
file.CMakeLists.txt
file in theminiapps
directory, if the new miniapp is in a new directory.CMakeLists.txt
file in the new miniapp directory.doc/CodeDocumentation.dox
miniapps/nurbs
), add it toMINIAPP_SUBDIRS
in themakefile
.miniapps/nurbs
), list it indoc/CodeDocumentation.conf.in
src/meshing.md
andsrc/electromagnetics.md
files.src/examples.md
andsrc/img
.features.md
.mfem/web
repo.README
(rare).doc/CodeDocumentation.dox
(rare).make unittest
to make sure all unit tests pass.tests/scripts
.