Disable Error Diagnostic Modal In Embedding #42641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sloansparger
approved these changes
May 14, 2024
|
|
||
| const tooltipMessage = isEmbedded | ||
| ? message | ||
| : message + t` Click for more information`; |
There was a problem hiding this comment.
not sure if the leading space will get trimmed or not
johnswanson
pushed a commit
that referenced
this pull request
May 14, 2024
* Disable Error Diagnostic Modal In Embedding * add e2e test for diagnostic modal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #40677
Description
The error diagnostic modal should not be accessible in embedded contexts, either by keyboard, or via error components.
Also, the
ctrl + F1keyboard shortcut should not work when embedded.The easiest way to test this is to modify the
getIsEmbeddedfunction to always return true;