Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use icons for "Line style" viz settings #42637

Merged
merged 2 commits into from
May 14, 2024
Merged

Use icons for "Line style" viz settings #42637

merged 2 commits into from
May 14, 2024

Conversation

kulyk
Copy link
Member

@kulyk kulyk commented May 14, 2024

Followup on #42043

Updates the "Line style" picker to use icons instead of labels like "Solid" and "Dashed"

Demo

Before After
before after

@kulyk kulyk added the .Team/DashViz Dashboard and Viz team label May 14, 2024
@kulyk kulyk requested review from kdoh and a team May 14, 2024 12:02
@kulyk kulyk self-assigned this May 14, 2024
@metabase-bot metabase-bot bot added the visual Run Percy visual testing label May 14, 2024
Copy link

Codenotify: Notifying subscribers in CODENOTIFY files for diff c594662...06f37c8.

Notify File(s)
@alxnddr frontend/src/metabase/visualizations/lib/settings/series.js
@kdoh frontend/src/metabase/ui/components/icons/Icon/icons/index.ts
frontend/src/metabase/ui/components/icons/Icon/icons/line_style-dashed.svg
frontend/src/metabase/ui/components/icons/Icon/icons/line_style-dotted.svg
frontend/src/metabase/ui/components/icons/Icon/icons/line_style-solid.svg

@kulyk kulyk changed the title Add icons Use icons for "Line style" viz settings May 14, 2024
@kulyk kulyk added the no-backport Do not backport this PR to any branch label May 14, 2024
Copy link

replay-io bot commented May 14, 2024

Status Complete ↗︎
Commit 06f37c8
Results
⚠️ 3 Flaky
2505 Passed

@kulyk kulyk merged commit 706a553 into master May 14, 2024
131 of 150 checks passed
@kulyk kulyk deleted the update-line-style-icons branch May 14, 2024 17:01
Copy link

@kulyk Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/DashViz Dashboard and Viz team visual Run Percy visual testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants