Fix broken metric revision API call #42634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nemanjaglumac
commented
May 14, 2024
Comment on lines
+249
to
+260
| cy.log("Make sure the revision history works (metabase#42633"); | ||
| cy.get("tbody tr").icon("ellipsis").click(); | ||
| popover().findByTextEnsureVisible("Revision History").click(); | ||
| cy.location("pathname").should( | ||
| "eq", | ||
| "/admin/datamodel/metric/1/revisions", | ||
| ); | ||
| cy.findByRole("heading").should( | ||
| "have.text", | ||
| 'Revision History for "ORDERS"', | ||
| ); | ||
| cy.findAllByRole("listitem").should("contain", "time for a change"); |
There was a problem hiding this comment.
The relevant bit for the repro.
nemanjaglumac
commented
May 14, 2024
Comment on lines
+62
to
+76
| cy.log( | ||
| "Make sure this is reflected in the revision history (metabase#42633)", | ||
| ); | ||
| cy.findAllByRole("listitem") | ||
| .filter(':contains("Revision history for orders < 100")') | ||
| .click(); | ||
|
|
||
| cy.location("pathname").should( | ||
| "eq", | ||
| `/reference/metrics/${id}/revisions`, | ||
| ); | ||
| cy.findAllByRole("listitem").should( | ||
| "contain", | ||
| "Renaming the description", | ||
| ); |
There was a problem hiding this comment.
The relevant bit for the repro.
ranquild
approved these changes
May 14, 2024
|
@nemanjaglumac Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
johnswanson
pushed a commit
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR Fixes #42633 that broke in two places:
It adds E2E reproductions for both cases.
It also consolidates some of the existing tests (but this was just a boy scout cleanup)
How to verify
Checklist