Move series data label formatters from option to the model
#42616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- TODO: move stacked data label formatters to the model
JesseSDevaney
force-pushed
the
move-data-label-formatting-to-model
branch
from
da7941c
to
952084c
Compare
…label-formatting-to-model
JesseSDevaney
changed the base branch from
master
to
propagate-combo-stacking-to-areas-bars
* propagate combo stacking to area and bar charts * enable combo stacking for bar/area charts, fix data transform * fix types, specs * fix y-axis extents calculations * remove spec that tested the removed control, update specs, update test data
Base automatically changed from
propagate-combo-stacking-to-areas-bars
to
combo-stacked-chart
May 14, 2024 19:40
JesseSDevaney
force-pushed
the
move-data-label-formatting-to-model
branch
from
fa00fc1
to
5225689
Compare
* propagate combo stacking to area and bar charts * enable combo stacking for bar/area charts, fix data transform * fix types, specs * fix y-axis extents calculations * remove spec that tested the removed control, update specs, update test data
alxnddr
force-pushed
the
combo-stacked-chart
branch
from
c0866d9
to
3ef60e9
Compare
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff c059690...b261af8.
|
|
* refactor function * remove "graph.show_values" conditional for "graph.label_value_formatting" section - removed this conditional since this formatting option will now apply to the y-axis as well * sync axis compact formatting with series/stacked/waterfall compact formatting * compact y-axis tick values even if no values are shown on data points * adjust auto compacting length difference * add stories for compacting y-axis * Update Loki Snapshots * update bar-auto-formatting-full * rename parameter * revert compact formatting threshold * rename variable * fix E2E spec y-axis tick value check - since tick values can now be compacted, this test had to be updated because it fit within those conditions for compact formatting * refactor y-axis compact formatting check * improve padding between y-axis label and tick-values * update loki visualization files - since the margin between the y-axis label and y-axis tick values was increased, all of the loki files are being updated * revert axisNameMargin change * fix padding * update loki snapshots * refactor getValuesToMeasure * conditionally test extra y-tick values
|
@JesseSDevaney Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After Changes
2024-05-14.19-52-45.mp4
@alxnddr At :55, it appears there is a new edge case introduced by stacked combo charts with non-stacked/regular lines. The ability to toggle
Show values for this seriesis hidden even though it is still a viable option in this new paradigm. Would you be able to account for this in your combo stacked chart PR?