Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(3/n) update legend for other series grouping #42615

Draft
wants to merge 2 commits into
base: other_bar
Choose a base branch
from
Draft

(3/n) update legend for other series grouping #42615

wants to merge 2 commits into from

Conversation

EmmadUsmani
Copy link
Contributor

@EmmadUsmani EmmadUsmani commented May 14, 2024 •
edited

Part of #41986

Description

Updates the legend to correctly display the other series, and to highlight it upon hover.

Note that the click actions menu for breakouts on the other series hasn't been implemented yet, I'll revisit that in a later PR.

How to verify

Screenshot 2024-05-13 at 6.25.20 PM.png

Screenshot 2024-05-13 at 6.30.35 PM.png

@EmmadUsmani Graphite App
Copy link
Contributor Author

EmmadUsmani commented May 14, 2024 •
edited

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EmmadUsmani and the rest of your teammates on Graphite Graphite

@EmmadUsmani EmmadUsmani mentioned this pull request May 14, 2024
Draft
@metabase-bot metabase-bot bot added the .Team/DashViz Dashboard and Viz team label May 14, 2024
@EmmadUsmani EmmadUsmani force-pushed the update_legend_for_other_series_grouping branch 2 times, most recently from 5678ed7 to e1ad397 Compare May 14, 2024 01:06
@EmmadUsmani EmmadUsmani changed the title update legend for other series grouping (3/n) update legend for other series grouping May 14, 2024
@EmmadUsmani EmmadUsmani marked this pull request as ready for review May 14, 2024 01:31
@EmmadUsmani EmmadUsmani added the no-backport Do not backport this PR to any branch label May 14, 2024 — with Graphite App
@metabase-bot metabase-bot bot added the visual Run Percy visual testing label May 14, 2024
@EmmadUsmani EmmadUsmani requested a review from a team May 14, 2024 01:31
@EmmadUsmani EmmadUsmani force-pushed the update_legend_for_other_series_grouping branch from e1ad397 to 488c057 Compare May 14, 2024 01:37
@github-actions GitHub Actions
Copy link

Codenotify: Notifying subscribers in CODENOTIFY files for diff 0f93468...488c057.

Notify File(s)
@alxnddr frontend/src/metabase/visualizations/echarts/cartesian/model/guards.ts
frontend/src/metabase/visualizations/echarts/cartesian/model/legend.ts
frontend/src/metabase/visualizations/visualizations/CartesianChart/CartesianChart.tsx
frontend/src/metabase/visualizations/visualizations/CartesianChart/use-chart-events.ts
frontend/src/metabase/visualizations/visualizations/CartesianChart/use-models-and-option.ts
frontend/src/metabase/visualizations/visualizations/CartesianChart/utils.ts

@replay-io replay.io
Copy link

replay-io bot commented May 14, 2024 •
edited

Status In Progress ↗︎ 51 / 52
Commit 488c057
Results
❌ 2 Failed
⚠️ 4 Flaky
✅ 2501 Passed

@EmmadUsmani EmmadUsmani marked this pull request as draft May 14, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxnddr alxnddr alxnddr approved these changes

Assignees

@EmmadUsmani EmmadUsmani

Labels
no-backport Do not backport this PR to any branch .Team/DashViz Dashboard and Viz team visual Run Percy visual testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EmmadUsmani @alxnddr