-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace search bar with command palette toggle #42603
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good.
I still think the button looks funny. 🤷♂️
3a774f6
to
468ec6c
Compare
@@ -202,9 +202,11 @@ function testOfficialBadgeInSearch({ | |||
question, | |||
expectBadge, | |||
}) { | |||
appBar().findByPlaceholderText("Search…").as("searchBar").type(searchQuery); | |||
// appBar().findByPlaceholderText("Search…").as("searchBar").type(searchQuery); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete
|
||
["admin", "normal"].forEach(user => { | ||
describe(`search > ${user} user`, () => { | ||
beforeEach(() => { | ||
restore(); | ||
cy.signIn(user); | ||
cy.visit("/"); | ||
// cy.visit("/"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗑️
Closes #42346
Description
PR swaps out the search bar for a button in the
AppBar
component when we are not embedded. Button should toggle the command palette. Tests were updated to eitherHow to verify
Demo
Checklist