[Drivers] New features to replace hard-coded driver lists in tests
#42602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @bshepherdson and the rest of your teammates on |
|
- `:metadata/key-constraints` for those databases which formally track PK and FK key constraints. Some databases (eg. Presto/Athena/Starburst family) don't support constraints like that, but do support querying based on foreign keys (which is the `:foreign-keys` feature). - `:connection/multiple-databases` for databases where a single connection can connect to many databases. This is the case for Athena, since it connects to an S3 bucket and exposes all files in the bucket as databases through that single connection. - Also removed a troublesome "all DBs except a huge list" case in the SSH tunnel tests with a shorter list of supported drivers.
bshepherdson
force-pushed
the
drivers-features-for-key-constraints-and-multi-db
branch
from
9d3dcaf
to
53a6236
Compare
bshepherdson
deleted the
drivers-features-for-key-constraints-and-multi-db
branch
|
@bshepherdson Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
bshepherdson
added a commit
that referenced
this pull request
May 22, 2024
These were added in #42602 but I neglected to update the changelog. Their defaults should serve for most drivers.
bshepherdson
added a commit
that referenced
this pull request
May 22, 2024
These were added in #42602 but I neglected to update the changelog. Their defaults should serve for most drivers.
github-actions bot
pushed a commit
that referenced
this pull request
May 22, 2024
These were added in #42602 but I neglected to update the changelog. Their defaults should serve for most drivers.
oisincoveney
pushed a commit
that referenced
this pull request
May 22, 2024
These were added in #42602 but I neglected to update the changelog. Their defaults should serve for most drivers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:metadata/key-constraintsfor those databases which formally trackPK and FK key constraints. Some databases (eg. Presto/Athena/Starburst
family) don't support constraints like that, but do support querying
based on foreign keys (which is the
:foreign-keysfeature).:connection/multiple-databasesfor databases where a singleconnection can connect to many databases. This is the case for Athena,
since it connects to an S3 bucket and exposes all files in the bucket
as databases through that single connection.
SSH tunnel tests with a shorter list of supported drivers.