propagate combo stacking to area and bar charts #42600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxnddr
force-pushed
the
propagate-combo-stacking-to-areas-bars
branch
from
e17fa52
to
a992419
Compare
|
alxnddr
force-pushed
the
combo-stacked-chart
branch
from
1ebd298
to
c233fd8
Compare
alxnddr
force-pushed
the
propagate-combo-stacking-to-areas-bars
branch
from
e812eaa
to
f23eb15
Compare
alxnddr
force-pushed
the
propagate-combo-stacking-to-areas-bars
branch
from
f23eb15
to
5a3ae84
Compare
EmmadUsmani
approved these changes
May 14, 2024
| @@ -363,13 +368,15 @@ function getStackedValueTransformFunction( | |||
| }, 0); | |||
| const rawTotal = rawBelowTotal + getNumberOrZero(datum[seriesDataKey]); | |||
|
|
|||
| const transformedRawBelowTotal = valueTransform(rawBelowTotal) ?? 0; | |||
There was a problem hiding this comment.
Would be better on line 377 so it's underneath the comment explaining that step.
| @@ -577,18 +580,5 @@ describe("dataset transform functions", () => { | |||
| expect(result[1][X_AXIS_DATA_KEY]).toBe(5); | |||
| expect(result[2][X_AXIS_DATA_KEY]).toBe(1000); | |||
| }); | |||
|
|
|||
| it("handles empty datasets without errors", () => { | |||
There was a problem hiding this comment.
What's the context for this test being deleted?
There was a problem hiding this comment.
It looks like this test here is the result of some rebase in the past because it was in the describe("getTransformedDataset", () => {}) group while testing applyVisualizationSettingsDataTransformations which is a newer name. And there is already a "should work on empty datasets" test of applyVisualizationSettingsDataTransformations
alxnddr
added a commit
that referenced
this pull request
May 14, 2024
* propagate combo stacking to area and bar charts * enable combo stacking for bar/area charts, fix data transform * fix types, specs * fix y-axis extents calculations * remove spec that tested the removed control, update specs, update test data
alxnddr
added a commit
that referenced
this pull request
May 16, 2024
* combo stacked chart * spec * remove irrelevant spec * combo stacking * fix selecting y-axis on stacked charts * snapshot * linter, specs, types * propagate combo stacking to area and bar charts (#42600) * propagate combo stacking to area and bar charts * enable combo stacking for bar/area charts, fix data transform * fix types, specs * fix y-axis extents calculations * remove spec that tested the removed control, update specs, update test data * review * show show data values setting on normalized charts that have a line series * fixes
JesseSDevaney
added a commit
that referenced
this pull request
May 17, 2024
* move series data label formatters to the model - TODO: move stacked data label formatters to the model * combo stacked chart * spec * remove irrelevant spec * combo stacking * fix selecting y-axis on stacked charts * snapshot * linter, specs, types * propagate combo stacking to area and bar charts * enable combo stacking for bar/area charts, fix data transform * fix types, specs * fix y-axis extents calculations * remove spec that tested the removed control, update specs, update test data * propagate combo stacking to area and bar charts (#42600) * propagate combo stacking to area and bar charts * enable combo stacking for bar/area charts, fix data transform * fix types, specs * fix y-axis extents calculations * remove spec that tested the removed control, update specs, update test data * review * remove unused formatting options parameter * move stacked labels formatter to model * fix stacked combo chart label display for non-stacked lines * combo stacked chart * spec * remove irrelevant spec * combo stacking * fix selecting y-axis on stacked charts * snapshot * linter, specs, types * propagate combo stacking to area and bar charts (#42600) * propagate combo stacking to area and bar charts * enable combo stacking for bar/area charts, fix data transform * fix types, specs * fix y-axis extents calculations * remove spec that tested the removed control, update specs, update test data * review * fix waterfall chart labels --------- Co-authored-by: Aleksandr Lesnenko <alxnddr@gmail.com> Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic #41976
Description
This PR enables creating stacked combo charts for Bar/Area visualizations. It requires removing
Stacked chart typewhich allowed to override area/bar chart type:It was a convenient way to switch between area/bar appearance although redundant. Now this setting does not make sense since it is possible to have both area and bar stacks on the same chart.
This PR also fixes the issue on non-linear y-axis scales when some series were stacked and others don't.
How to verify
Demo
Checklist