Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate dependencies included into bundle #42553

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

uladzimirdev
Copy link
Contributor

@uladzimirdev uladzimirdev commented May 13, 2024

Closes #42555

Description

Deduplicate some package

  • bn.js
Screenshot 2024-05-13 at 11 24 55
  • react-draggable
Screenshot 2024-05-13 at 11 20 28
  • call-bind
  • classnames
  • react-redux
Screenshot 2024-05-13 at 11 19 54

How to verify

  • rely on tests
  • drag&drop using react-beautiful-dnd works

Demo

Before

Screenshot 2024-05-13 at 11 18 11

After

Screenshot 2024-05-13 at 11 18 03

@uladzimirdev uladzimirdev changed the title dedup bundle Deduplicate dependencies included into bundle May 13, 2024
@uladzimirdev uladzimirdev added the no-backport Do not backport this PR to any branch label May 13, 2024
@@ -272,7 +272,7 @@
"mockdate": "^2.0.2",
"mutationobserver-shim": "^0.3.7",
"mysql2": "^3.9.7",
"node-polyfill-webpack-plugin": "2.0.1",
"node-polyfill-webpack-plugin": "^3.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

side change, but why not

Copy link

replay-io bot commented May 13, 2024

Status Complete ↗︎
Commit e976926
Results
⚠️ 3 Flaky
2497 Passed

@npfitz
Copy link
Contributor

npfitz commented May 13, 2024

We can probably test metabase with react-draggable@4.4.3, and I expect it'll be fine. We upgraded from 3.x last month... the only real goal was to get us on 4.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/QueryingComponents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deduplicate duplicated packages
2 participants