Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG-1673,1690] Resolve horizontal scrolling and add spacing b/w sidebar and catalogs #1691

Merged
merged 3 commits into from
May 17, 2024

Conversation

Muhammed-Moinuddin
Copy link
Contributor

Description

This PR fixes # 1673 and 1690

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

resolve message-header width issue,  image overflow and height issue \n added border-radius to images for design consistency

Signed-off-by: Muhammad Moinuddin <moinuddinilyas786@gmail.com>
Signed-off-by: Muhammad Moinuddin <moinuddinilyas786@gmail.com>
Copy link

netlify bot commented Mar 30, 2024

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit 2bea4b8
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/66474bfeacb88c00073d85ae
😎 Deploy Preview https://deploy-preview-1691--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vishalvivekm
Copy link
Member

@Muhammed-Moinuddin
Let's discuss this on websites call. Add this as an agenda item to the meeting minutes, if you would :)

@sudhanshutech
Copy link
Member

@Muhammed-Moinuddin please describe what you are fixing in the pr description and ensure to properly tag the issue you are working on.

@Muhammed-Moinuddin
Copy link
Contributor Author

@Muhammed-Moinuddin
Let's discuss this on websites call. Add this as an agenda item to the meeting minutes, if you would :)

Noted!

@Muhammed-Moinuddin
Copy link
Contributor Author

@Muhammed-Moinuddin please describe what you are fixing in the pr description and ensure to properly tag the issue you are working on.

Noted!

@ritiksaxena124
Copy link
Contributor

Hey @Muhammed-Moinuddin let's discuss this on today's website meet (https://meet.layer5.io/websites) if you are available. I have added it as an agenda item

@Muhammed-Moinuddin
Copy link
Contributor Author

Hey @Muhammed-Moinuddin let's discuss this on today's website meet (https://meet.layer5.io/websites) if you are available. I have added it as an agenda item

I'll try but I won't be to join today.

Copy link

stale bot commented May 16, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label May 16, 2024
@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label May 16, 2024
Copy link
Contributor

@iArchitSharma iArchitSharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iArchitSharma iArchitSharma merged commit 7f13d68 into meshery:master May 17, 2024
6 checks passed
Copy link

welcome bot commented May 17, 2024

Thanks for your contribution to the Layer5 and Meshery community! 🎉

Meshery Logo
        ⭐ Please leave a star on the project. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants