Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(ClassDiagram): Fixed a combination abstract and static modifiers not working. #5462

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

TeaDrinkingProgrammer
Copy link

@TeaDrinkingProgrammer TeaDrinkingProgrammer commented Apr 14, 2024

📑 Summary

This pull requests fixes a combination of abstract and static modifiers not working.

Resolves #5459

📏 Design Decisions

I updated the RegEx for detecting methods to take into account a possible combination of $* instead of just * or $. In that process I also found out that the last capture group didn't do anything because a "hack" was used where it checked if the last character was $ or *. This was removed.

For the fields, a similar tactic of checking for the first and last characters was replaced with a RegEx similar to the first one.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features. --> Will add an issue later for documentation.
  • 🔖 targeted develop branch

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Apr 14, 2024
Copy link

netlify bot commented Apr 14, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 582d774
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/661ec13f52e29e0008c9705e
😎 Deploy Preview https://deploy-preview-5462--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 5.73%. Comparing base (e570863) to head (582d774).
Report is 58 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #5462      +/-   ##
==========================================
- Coverage     5.74%   5.73%   -0.02%     
==========================================
  Files          277     278       +1     
  Lines        41897   41999     +102     
  Branches       489     490       +1     
==========================================
  Hits          2407    2407              
- Misses       39490   39592     +102     
Flag Coverage Δ
unit 5.73% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/mermaid/src/diagrams/class/classTypes.ts 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

@TeaDrinkingProgrammer
Copy link
Author

Is there anything I can do to get this PR merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Class diagram: static abstract method does not work
1 participant