Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update segment and reqwest to the latest version #4630

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update segment and reqwest to the latest version #4630

wants to merge 1 commit into from

Conversation

irevoire
Copy link
Member

Continue the work of #4622

@irevoire irevoire added this to the v1.9.0 milestone May 13, 2024
@irevoire irevoire requested a review from Kerollmops May 13, 2024 08:27
Kerollmops
Kerollmops requested changes May 13, 2024
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What saddens me is that we are increasing the number of dependencies by updating reqwest and segment. We should look further into this to shrink the Cargo.lock, instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerollmops Kerollmops Kerollmops requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@irevoire @Kerollmops