Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new version of grenad with glidesort experiments in it #3500

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Kerollmops
Copy link
Member

@Kerollmops Kerollmops commented Feb 15, 2023

This PR experiments with using glidesort as the new algorithm in the Sorter. According to the graphs, it should show incredible performance gains. It is based on meilisearch/grenad#39.

  • Here is the GitHub Action for the baseline (main, 91ce8a5).
  • And the GitHub Action for this PR where we only replace the stable sort operation (feature glidesort-stable).
  • We will see if we can replace the unstable sort with glidesort. The issue is that glidesort allocates, not the std unstable sort (feature glidesort-unstable).

@Kerollmops Kerollmops added the enhancement New feature or improvement label Feb 15, 2023
@github-actions
Copy link

Uffizzi Preview Environment Deploying

☁️ https://app.uffizzi.com/github.com/meilisearch/meilisearch/pull/3500

⚙️ Updating now by workflow run 4185248753.

The meilisearch preview environment contains a web terminal from where you can run the
meilisearch command. You should be able to access this instance of meilisearch running in
the preview from the link Meilisearch Endpoint link given below.

Web Terminal Endpoint :
Meilisearch Endpoint : /meilisearch

@Kerollmops Kerollmops modified the milestone: v1.1.0 Feb 15, 2023
@Kerollmops
Copy link
Member Author

I was able to retrieve the output files. Unfortunately, the performance gain is not noticeable at all...

group                                                                     indexing_glidesort-grenad-experiments_ddf72299    indexing_main_91ce8a5e
-----                                                                     ----------------------------------------------    ----------------------
indexing/-geo-delete-facetedNumber-facetedGeo-searchable-                 1.20     43.1±6.04ms        ? ?/sec               1.00     35.8±3.30ms        ? ?/sec
indexing/-movies-delete-facetedString-facetedNumber-searchable-           1.00     10.0±6.60ms        ? ?/sec               1.00     10.0±5.98ms        ? ?/sec
indexing/-movies-delete-facetedString-facetedNumber-searchable-nested-    1.00     15.0±4.43ms        ? ?/sec               1.11     16.6±4.94ms        ? ?/sec
indexing/-songs-delete-facetedString-facetedNumber-searchable-            1.33    54.3±15.05ms        ? ?/sec               1.00     40.9±3.81ms        ? ?/sec
indexing/-wiki-delete-searchable-                                         1.07   213.3±21.87ms        ? ?/sec               1.00    199.3±8.90ms        ? ?/sec
indexing/Indexing geo_point                                               1.00      49.6±0.54s        ? ?/sec               1.00      49.8±0.76s        ? ?/sec
indexing/Indexing movies in three batches                                 1.07       9.9±0.26s        ? ?/sec               1.00       9.2±0.26s        ? ?/sec
indexing/Indexing movies with default settings                            1.08       8.1±0.39s        ? ?/sec               1.00       7.5±0.10s        ? ?/sec
indexing/Indexing nested movies with default settings                     1.07       7.3±0.45s        ? ?/sec               1.00       6.9±0.33s        ? ?/sec
indexing/Indexing nested movies without any facets                        1.10       6.9±0.20s        ? ?/sec               1.00       6.3±0.17s        ? ?/sec
indexing/Indexing songs in three batches with default settings            1.00      43.6±1.04s        ? ?/sec               1.00      43.7±1.15s        ? ?/sec
indexing/Indexing songs with default settings                             1.01      40.6±0.88s        ? ?/sec               1.00      40.1±0.81s        ? ?/sec
indexing/Indexing songs without any facets                                1.00      36.2±0.62s        ? ?/sec               1.00      36.2±0.78s        ? ?/sec
indexing/Indexing songs without faceted numbers                           1.00      38.4±0.46s        ? ?/sec               1.01      38.7±0.91s        ? ?/sec
indexing/Indexing wiki                                                    1.01     635.7±2.85s        ? ?/sec               1.00     630.0±6.32s        ? ?/sec
indexing/Indexing wiki in three batches                                   1.01     683.7±4.95s        ? ?/sec               1.00     679.7±6.26s        ? ?/sec
indexing/Reindexing geo_point                                             1.00      14.4±0.21s        ? ?/sec               1.00      14.4±0.06s        ? ?/sec
indexing/Reindexing movies with default settings                          1.15   327.0±26.79ms        ? ?/sec               1.00   284.7±24.05ms        ? ?/sec
indexing/Reindexing songs with default settings                           1.03       3.6±0.16s        ? ?/sec               1.00       3.5±0.03s        ? ?/sec
indexing/Reindexing wiki                                                  1.01   1075.6±23.31s        ? ?/sec               1.00    1061.3±4.61s        ? ?/sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant