Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethink #376

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from
Draft

Rethink #376

wants to merge 18 commits into from

Conversation

matthiasbeyer
Copy link
Collaborator

@matthiasbeyer matthiasbeyer commented Sep 17, 2022 •
edited

This is my "rethink" efforts.

As this effort is done to overthink the architecture of the whole codebase, it removes the old code entirely and replaces it with my re-think work.

I hope interested parties will have a look.

Relevant issues:

(maybe more will be added here)

Filed as draft, because this will be rebased as I see fit. So do not base any work on this except you want to add something to this PR!

@matthiasbeyer
Remove world, to start from a clean slate
8688608 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Add first mockup
9d6be62 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Add ConfigObject::new() for creating config objects in tests
140d740 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Add tests for loading sources
9e2a845 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Add Accessor implementation
f1c7662 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Add StringSource
b2ba820 
This patch adds a type for a String buffer as a source for the
configuration as well as format parser interfaces.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Add TOML parser backend
65561da 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Add tests for layered configuration
db442a6 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Make Accessor type an index helper
87a6205 
This patch changes the Accessor type to be a helper over a list of
AccessType objects.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Move traversal to ConfigElement impl
0daf2b0 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Add test for nested TOML configuration
f1293c0 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Add test for array-nested TOML configuration
024d97e 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Split config into several submodules
9bf609f 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Add async config builder
4866d79 
This patch also removes the associated error type from the ConfigSource
trait, as we figured out that this can be simply a SourceError.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Rewrite to store loaders _and_ loaded config
a234c08 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Remove asyncness
6de1c4b 
This patch removes the async loading.
The async loading makes everything awefully complicated and in fact it
should rather be solved on the user side of things, not within this
crate.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
cargo-fmt
c45b213 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Rework visibility and export types that are required for working with…
42a2b26 
… the crate

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer matthiasbeyer added this to In progress in Re-thinking config-rs Sep 17, 2022
@matthiasbeyer matthiasbeyer mentioned this pull request Nov 3, 2022
Closed
@FlixCoder
Copy link

Do you think it would be possible to generate sample configs including doc comments with the new approach? Or would it still need a separate macro to get the doc comments?

I am thinking about writing a macro for generating sample configs with documentation of the fields.

@matthiasbeyer
Copy link
Collaborator Author

I could imagine that it would be possible.

@milesj
Copy link

milesj commented Jan 1, 2023

Is there any progress on this? I'm looking to move away from figment, and this crate is probably the best choice, but based on all the refactor talk, I'm hesitant to move to it.

@matthiasbeyer
Copy link
Collaborator Author

Is there any progress on this?

There's progress here: https://github.com/matthiasbeyer/config-rs-ng - still slow, but at least there's progress!

I'm looking to move away from figment, and this crate is probably the best choice, but based on all the refactor talk, I'm hesitant to move to it.

The current config-rs version is still usable 😆 - If we decide to move to the rewritten version, there will be a grace period and (if possible) compatible interfaces to make the move less complicated!

@milesj
Copy link

milesj commented Jan 2, 2023

Thanks for the update, I'll keep an eye on it 👍

@matthiasbeyer matthiasbeyer mentioned this pull request Jan 19, 2023
Open
@jpmckinney jpmckinney mentioned this pull request Aug 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Re-thinking config-rs
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthiasbeyer @FlixCoder @milesj