Add test for overwriting key from env #370
Open
+47
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
|
That's fast! :). Thanks @matthiasbeyer |
|
Don't get too excited, this is just a test. I do not have a fix yet 😆 |
|
Heheh just noticed this. Still, thanks! :) |
|
I would like to send a PR. Can you point me where overwrites happen in the code path? |
The comment on the assert!() explains why this is not expecting an Error. Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
|
Okay, so the fix would be to not alias the field. That's unfortunately the only fix I see right now because of the way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address #369