Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: pick the default store region #7369

Merged
merged 8 commits into from
May 21, 2024
Merged

chore: pick the default store region #7369

merged 8 commits into from
May 21, 2024

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented May 20, 2024 •
edited

what:

  • adds a default region to be created on first load
  • when picking any region for cart, we pick the default region of the store.

@vercel Vercel
Copy link

vercel bot commented May 20, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 21, 2024 9:11am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 9:11am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs-ui ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 9:11am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 9:11am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 20, 2024 •
edited

⚠️ No Changeset found

Latest commit: 5a1e2ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@riqwan riqwan marked this pull request as ready for review May 20, 2024 12:26
@riqwan riqwan requested a review from a team as a code owner May 20, 2024 12:26
sradevski
sradevski reviewed May 20, 2024
View reviewed changes
integration-tests/modules/__tests__/cart/store/carts.spec.ts Outdated Show resolved Hide resolved
packages/core/core-flows/src/defaults/steps/create-default-region.ts Outdated Show resolved Hide resolved
packages/core/core-flows/src/defaults/steps/create-default-store.ts Outdated Show resolved Hide resolved
packages/core/core-flows/src/defaults/steps/create-default-store.ts Outdated Show resolved Hide resolved
packages/core/core-flows/src/definition/cart/steps/find-one-or-any-region.ts Outdated
const storeModule = container.resolve<IStoreModuleService>(
ModuleRegistrationName.STORE
)

if (!data.regionId) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be easier to read if it is if(data.regionId) instead.

riqwan
riqwan commented May 21, 2024
View reviewed changes
integration-tests/modules/__tests__/cart/store/cart.workflows.spec.ts
name: "Default Region",
currency_code: "dkk",
})
const { region } = await seedStorefrontDefaults(appContainer, "dkk")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrien2p @sradevski keeping this in the test file as its not required for most specs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good 👍

@riqwan riqwan requested a review from sradevski May 21, 2024 09:10
@riqwan riqwan merged commit 43613f3 into develop May 21, 2024
17 checks passed
@riqwan riqwan deleted the feat/store-region branch May 21, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sradevski sradevski sradevski approved these changes

@adrien2p adrien2p adrien2p approved these changes

@carlos-r-l-rodrigues carlos-r-l-rodrigues Awaiting requested review from carlos-r-l-rodrigues carlos-r-l-rodrigues is a code owner automatically assigned from medusajs/engineering

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

@olivermrbl olivermrbl Awaiting requested review from olivermrbl

Assignees
No one assigned
Labels
team: medusa type: chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@riqwan @sradevski @adrien2p @olivermrbl