Implementing chain search for the MockClient #3714
Draft
+339
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- it does not handle multiple links - it does not handle reverse chains
I havent been able to find an example of chaining regular chains yet. Not sure if spec allows for that.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
|
@jjdonov is attempting to deploy a commit to the Medplum Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I was interested in getting chained searches working w/ the mock client, and was hoping to get some feedback on the approach taken so far, and in particular to check on the usage of SearchParamDetails and the columnName attribute.
Approach Overview:
server. So that it can be used both byserverandfhir-routerits moved tocorematch.tsonly handles matching w/ a single resource. Matching for a chain requires being able to resolve the linked resources. e.g. To cope with that, thematchesChainis implemented inMemoryRepositoryinstead of as a part ofmatchOpen Questions
SearchParamDetails.columnNameto make sure the linked resource has a reference to the parent.columnNamesuggests that it might be a server-centric concept, but was already incore. Is this safe to use?Feedback already provided by @rahul1