-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: Update Serial Driver #11536
base: master
Are you sure you want to change the base?
Conversation
5f03c82
to
67b8fd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just have a question regarding duplicate hardware device information across the project
customTable.addProduct(QGCUsbId.VENDOR_PX4, QGCUsbId.DEVICE_PX4FMU_V2, CdcAcmSerialDriver.class); | ||
customTable.addProduct(QGCUsbId.VENDOR_PX4, QGCUsbId.DEVICE_PX4FMU_V3, CdcAcmSerialDriver.class); | ||
customTable.addProduct(QGCUsbId.VENDOR_PX4, QGCUsbId.DEVICE_PX4FMU_V4, CdcAcmSerialDriver.class); | ||
customTable.addProduct(QGCUsbId.VENDOR_PX4, QGCUsbId.DEVICE_PX4FMU_V4PRO, CdcAcmSerialDriver.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add the whole list of FMU versions here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this list (the entire custom table) is the only part I really have no idea about, as I can't test every device. The cube I used worked without the use of the customTable entirely. I honestly am not sure what to put in it or not.
public static final int DEVICE_PX4FMU_V6U = 0x0036; | ||
public static final int DEVICE_PX4FMU_V6X = 0x0035; | ||
public static final int DEVICE_PX4FMU_V6XRT = 0x001D; | ||
public static final int DEVICE_PX4MINDPX_V2 = 0x0030; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like we already carry this information elsewhere, is there any way to avoid duplicating?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
USBBoardInfo.json, And I could probably come up with a way but I don't know Java well enough to do it easily. Maybe through CMake after we drop QMake.
67b8fd0
to
2a2b32c
Compare
@DonLakeFlyer this may be useful for your herelink build |
b7d8f75
to
5da0d15
Compare
5da0d15
to
6fcc4d5
Compare
6fcc4d5
to
e980efa
Compare
Allows Android to work with most devices. Tested by updating firmware on a cube orange.
fixes #11300
fixes #9052
closes #10629
#11007