Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not REQUEST_DATA_STREAMs by default, since it's deprecated #11531

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TishSerg
Copy link

Proof: https://mavlink.io/en/messages/common.html#REQUEST_DATA_STREAM

Description

MavLink command REQUEST_DATA_STREAM is DEPRECATED: Replaced by MAV_CMD_SET_MESSAGE_INTERVAL.
So, QGroundControl shouldn't use it by default.

Test Steps

  1. Install QGroundControl on clean machine where it wasn't installed before or wipe QGroundControl saved settings.
  2. Go to Application Settings, Telemetry, Stream Rates.
  3. See default setting of "Controlled By vehicle" checkbox slider (when it's ON it means REQUEST_DATA_STREAM is disabled).

Checklist:

Related Issue

#8304

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Collaborator

@HTRamsey HTRamsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to #11263

@TishSerg
Copy link
Author

On the other hand, if those streams aren't requested, QGC doesn't get necessary telemetry, like GPS position, battery, etc...

@HTRamsey
Copy link
Collaborator

I'd have to double check because I always use a message-intervals-chan1.txt file, but I thought they were generally sent by default.

@TishSerg
Copy link
Author

Sorry, I don't understand what you're talking about.

message-intervals-chan1.txt

Also, I can't find that file among QGC sources.

@HTRamsey
Copy link
Collaborator

It's somewhere in the ardupilot documentation, it's the way to set message rates on bootup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants