Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Ensure code coverage is always uploaded #28164

Merged
merged 1 commit into from
May 9, 2024

Commits on May 8, 2024

  1. CI: Ensure code coverage is always uploaded

    If code coverage is not uploaded on failure, then overall coverage can
    suffer mysteriously (e.g., if a mac system failed, then it would appear
    as if `backend_macosx.py` was not tested). Codecov would then show
    several "indirect changes" that are spurious.
    
    On GitHub Actions, if you don't have any status check function in the
    `if` entry, then it is treated as `success() && (whatever else you
    had)`, so put in an explicit check.
    
    Azure also had no condition, so defaulted to only-on-success.
    
    Cygwin is only run on `main` and sometimes on PRs, so disable code
    coverage reporting from it. That would cause random "reductions" in
    coverage for all PRs that don't run it (which is most of them.)
    
    Also, fix the image-cleanup script, which would only run on success
    instead of failure, where it would be useful.
    QuLogic committed May 8, 2024
    Configuration menu
    Copy the full SHA
    25847dd View commit details
    Browse the repository at this point in the history