Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperates edgecolor from hatchcolor #28104

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Impaler343
Copy link
Contributor

@Impaler343 Impaler343 commented Apr 19, 2024

PR summary

Taking after @Vashesh08 's PR #26993
Should close #26074 and #7059
Implemented the fallback logic that @story645 mentioned in this comment
Cherry picked some initial commits from the Issue26074 written by Vashesh
Modified the hatchcolor setting to way similar to edgecolor setting.

  • Need to do some extensive testing on patches and collections
  • Need to write documentation for hatchcolor attribute, and also describe the behaviour change
  • Need to rewrite the failing tests

PR checklist

@Impaler343 Impaler343 marked this pull request as draft April 24, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH]: Different edgecolor and hatch color in bar plot
2 participants