Add support for multiple hatches, edgecolors and linewidths in histograms #28073
Conversation
|
I'd suggest showing what this does with an example either in the GitHub pr description, or ideally in the gallery |
|
I'm not really sure if I need to add a new test or just modify an exisiting one(test_hist_stacked_bar) in test_axes.py |
|
I guess there are two things here:
|
|
pinging @story645 for review. The failing tests are unrelated |
lib/matplotlib/axes/_axes.py
Outdated
| if 'hatch' in kwargs: | ||
| kwargs['hatch'] = next(hatches) | ||
| if 'edgecolor' in kwargs: | ||
| kwargs['edgecolor'] = next(edgecolors) | ||
| if 'linewidth' in kwargs: | ||
| kwargs['linewidth'] = next(linewidths) |
There was a problem hiding this comment.
Can you use the kwarg names directly instead of this if chain? kinda like how it's implemented in pie
matplotlib/lib/matplotlib/axes/_axes.py
Lines 3339 to 3344 in 80b08bd
There was a problem hiding this comment.
yep, makes sense
| ax0.hist(x, n_bins, density=True, histtype='bar', color=colors, | ||
| label=colors, hatch=['o', '*', '.'], | ||
| edgecolor=['black', 'red', 'blue'], linewidth=[1, 2, 3]) | ||
| ax0.legend(prop={'size': 10}) | ||
| ax0.set_title('bars with legend') |
There was a problem hiding this comment.
my bias is to not do all of these in one example because I think it becomes really busy and you don't need it here because you can do it in the next line. Here's how I do it, but you don't have to: https://matplotlib.org/devdocs/gallery/pie_and_polar_charts/pie_features.html#sphx-glr-gallery-pie-and-polar-charts-pie-features-py
PR summary
Closes #26718 Distributes keyword args passed to each Patch using a cycler. Probably not the best way to do this?
PR checklist