New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enables setting hatch linewidth in Patches and Collections, also fixes setting hatch linewidth by rcParams #28048
base: main
Are you sure you want to change the base?
Conversation
I don't know why docs and CI are failing, could somebody please check this out? |
Hi @Impaler343, I'm not certain but I think the docs failure may be related to something that has been fixed on
Appveyor is showing the same failure on all PRs right now, so I wouldn't worry about that one. |
Do I also need to squash? |
{linewidth:f} setlinewidth | ||
{self._convert_path( | ||
Path.hatch(hatch), Affine2D().scale(sidelen), simplify=False)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you back these changes all the way out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes were done as flake8 failed while committing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flake8 should not have flagged either the g->f change or indentation in a multi-line string.
If flake8 is indeed triggering and requiring either of these changes that is a bug is flake8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've committing after skipping flake8, can't do anything else I think
There is enough exploration/experimentation in here it is probably worth squashing to a handful of commits. |
I think this is like 80% of the way there and looking pretty good! |
Can we get a feature for |
I do not think this is required? The reason |
I suggested this as it is a quick plugin to make tests run faster by focussing on the important part of the plot, by removing axes, labels and ticks, and this most probably should make a significant difference while running a large amount of tests |
return name | ||
|
||
hatchPatterns = _api.deprecated("3.8")(property(lambda self: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hatchPatterns = _api.deprecated("3.8")(property(lambda self: { | |
hatchPatterns = _api.deprecated("3.10")(property(lambda self: { |
An API change note is also required. See https://matplotlib.org/devdocs/devel/api_changes.html#deprecate-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please check if the API change note is written correctly? Also the failing test is unrelated
PR summary
Fixes #21108 using the patch provided by @anntzer which I modified to pass tests. Need to write tests for:
PR checklist