DOC: Clarify merge policy #28046
Merged
DOC: Clarify merge policy #28046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
force-pushed
the
doc-clarify-merge-policy
branch
from
5266d93
to
1aa9722
Compare
timhoffm
force-pushed
the
doc-clarify-merge-policy
branch
2 times, most recently
from
fc19cfc
to
10cc1b5
Compare
story645
reviewed
Apr 8, 2024
timhoffm
force-pushed
the
doc-clarify-merge-policy
branch
from
10cc1b5
to
07906dd
Compare
tacaswell
reviewed
Apr 9, 2024
timhoffm
commented
Apr 12, 2024
|
ping |
tacaswell
approved these changes
May 6, 2024
|
It is docs, but I would like a second review on this. |
|
I think this needs a rebase to pick up #28094. |
Co-authored-by: Thomas A Caswell <tcaswell@gmail.com>
timhoffm
force-pushed
the
doc-clarify-merge-policy
branch
from
9bc06ca
to
11de885
Compare
|
Possibly tangential to this PR but matplotlib/doc/devel/pr_guide.rst Lines 204 to 205 in 11de885 I am not on any dev mailing list. Should I be? |
Couldn't hurt, it's https://mail.python.org/mailman/listinfo/matplotlib-devel which follow up would maybe be cross linking to the mailing list list |
rcomer
approved these changes
May 9, 2024
|
Apologies for the tangent. Because of the context my brain went “wait, is there a mailing list for core devs?” |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by questions on some edge cases in the past (e.g. #28043 (review)).
One of the approvers should be @tacaswell .