Add support for horizontal CheckButtons #27946
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
force-pushed
the
horizontal-checkbuttons
branch
from
b58dc7d
to
f92a95f
Compare
A new optional keyword argument 'orientation' is introduced to control it. The new parameter defaults to 'vertical' for backwards compatibility.
QuLogic
force-pushed
the
horizontal-checkbuttons
branch
from
f92a95f
to
873a3d8
Compare
|
As a general remark: The buttons are placed above the text: I believe the more common placement text next to the buttons: I'm not blocking, but we should be clear what the desired result is and we're not accidentally moving into an unwanted direction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This is a followup to #13374, but for
CheckButtons. Also updates the test image to check both options.Feel free to review after #13374 or as a group. This is built on top of that one, so merging this would merge that as well.
PR checklist