Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport crash fixes to v3.7.x #27793

Merged
merged 5 commits into from
Feb 15, 2024
Merged

Backport crash fixes to v3.7.x #27793

merged 5 commits into from
Feb 15, 2024

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Feb 14, 2024

PR summary

Backports #27755 for the macOS crash, #27785 for PGF on Windows, and #26689 just to make the previous backport easier.

PR checklist

greglucas and others added 3 commits February 14, 2024 17:30
@greglucas @QuLogic
Merge pull request matplotlib#27755 from ksunden/release_gil_macos_ev…
d75d3a2 
…ent_loop

Allow threads during macos event loop

(cherry picked from commit b50843d)
@ksunden @QuLogic
Merge pull request matplotlib#26689 from anntzer/pgferr
240ff81 
Fix error generation for missing pgf.texsystem.

(cherry picked from commit 5f785e3)
@greglucas @QuLogic
Merge pull request matplotlib#27785 from tacaswell/fix/windows_pgf_sh…
7bf2554 
…utdown

FIX: be careful about communicating with subprocess
(cherry picked from commit c90234f)
@QuLogic
Bump pypa/cibuildwheel from 2.15.0 to 2.16.5
b8297e4 
This is a bunch of backports joined into one, as cibuildwheel 2.16.5
fixes a bug when building on Windows.
@ksunden
Copy link
Member

ksunden commented Feb 14, 2024

Test failures are because #27624 was not backported but pytest v8 is being used.

We can either add that to the backports or pin pytest on this branch.

@QuLogic QuLogic added this to the v3.7.5 milestone Feb 15, 2024
@QuLogic
Copy link
Member Author

QuLogic commented Feb 15, 2024 •
edited

Hmm, it seems like Python 3.8 and Pytest 8's new context manager setup isn't working well together for some reason.

@tacaswell
Copy link
Member

Maybe we should pin pytest back to less than 8 for this branch instead? It would be less code changes.

@ksunden
Copy link
Member

ksunden commented Feb 15, 2024

https://docs.python.org/3/whatsnew/3.10.html#parenthesized-context-managers

I'm confused as to why it works on 3.9, though... using parens in a with statement was apparently new in 3.10

@QuLogic @ksunden
Merge pull request matplotlib#27624 from ksunden/pytest8
e97c7f3 
Prepare for Pytest v8

(cherry picked from commit ed41aea)

Co-authored-by: Kyle Sunden <git@ksunden.space>
@ksunden ksunden merged commit 3d76f2d into matplotlib:v3.7.x Feb 15, 2024
37 checks passed
@QuLogic QuLogic deleted the backport-crash-fixes branch February 15, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksunden ksunden ksunden left review comments

@tacaswell tacaswell tacaswell approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
backend: pgf CI: Run cibuildwheel Run wheel building tests on a PR Maintenance OS: Apple OS: Microsoft
Projects
None yet
Milestone
v3.7.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@QuLogic @ksunden @tacaswell @dstansby @greglucas