-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
CI: Ensure code coverage is always uploaded
If code coverage is not uploaded on failure, then overall coverage can suffer mysteriously (e.g., if a mac system failed, then it would appear as if `backend_macosx.py` was not tested). Codecov would then show several "indirect changes" that are spurious. On GitHub Actions, if you don't have any status check function in the `if` entry, then it is treated as `success() && (whatever else you had)`, so put in an explicit check. Azure also had no condition, so defaulted to only-on-success. Cygwin is only run on `main` and sometimes on PRs, so disable code coverage reporting from it. That would cause random "reductions" in coverage for all PRs that don't run it (which is most of them.) Also, fix the image-cleanup script, which would only run on success instead of failure, where it would be useful.
- Loading branch information
Showing
3 changed files
with
6 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters