Move Goal actions into single actions column #22228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matomo-org/core-reviewers Can someone please review this PR? The failing builds appear to be unrelated to the changes in the PR. |
sgiehl
reviewed
May 17, 2024
|
@matomo-org/core-reviewers Can this PR be merged? I have a Funnels PR dependent on this one and I don't want to merge that until this one is merged. |
| @@ -86,21 +85,17 @@ | |||
|
|
|||
| <td v-if="userCanEditGoals" style="padding-top:2px"> | |||
| <button | |||
| v-if="userCanEditGoals" | |||
There was a problem hiding this comment.
The v-if on both buttons is superfluous as the whole column already has the same condition.
There was a problem hiding this comment.
True. I figured I'd leave it there in case a new action is added and the td's v-if condition changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Product has asked that we move table row actions into a combined Actions column. This is implementing that change for the Manage Goals table.
Review