-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated Import
model
#30345
base: main
Are you sure you want to change the base?
Remove deprecated Import
model
#30345
Conversation
This needs to be merged before we release our next major update, as it will prevent to update from a pre-4.2 version to the version containing this. |
You meant “after we release our next major update”? |
No, before we release it? So people can upgrade to the latest 4.x release (and we know they will have done the migration) then upgrade to 5.0 (which will require you to be up-to-date on the latest 4.x before upgrading to the next major) |
Ok, I think we do agree, I just was confused by your initial post as it seemed to imply the earlier it was merged, the better. The cost of merging it early is breaking in-progress imports for instances updating from pre-4.2.0 to a release containing this change. The cost of merging it late is carrying “dead” code for longer. I agree that 5.0 sounds like a good breakpoint to get rid of this. |
This pull request has merge conflicts that must be resolved before it can be merged. |
2377350
to
2293efa
Compare
This pull request has resolved merge conflicts and is ready for review. |
2293efa
to
d9fab6d
Compare
This pull request has merge conflicts that must be resolved before it can be merged. |
d9fab6d
to
8c2666d
Compare
This pull request has resolved merge conflicts and is ready for review. |
Attempting to remove the deprecated code from #21054