-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icon
field to instance endpoint
#30205
base: main
Are you sure you want to change the base?
Conversation
This pull request has merge conflicts that must be resolved before it can be merged. |
1c5880e
to
552d168
Compare
Updated to use the presenter from #30259 so the cache is used for the icons |
src = URI.join(root_url, src).to_s if src.present? | ||
|
||
{ | ||
src: src || frontend_asset_url("icons/android-chrome-#{size}x#{size}.png"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to make this output consistent with the thumbnail
property?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can, but there would be no blurhash
, and what should the keys be? The thumbnail uses @1x
, @2x
but I dont think it makes sense for the icons. Should we use size
?
This pull request has resolved merge conflicts and is ready for review. |
As we now allow admins to customize their app icon, it may be useful to expose it so apps can use it in the UI. This is using the Android icons as they provide a good range of sizes.
82c37c9
to
18bb0fa
Compare
18bb0fa
to
4146080
Compare
As we now allow admins to customize their app icon, it may be useful to expose it so apps can use it in the UI.
This is using the Android icons as they provide a good range of sizes.