Skip to content

Commit

Permalink
test: disable popup blocking for Cockpit-files
Browse files Browse the repository at this point in the history
In Cockpit-files we download using `window.open` which Chromium
sometimes blocks depending on how long the browser was open, the session
was active or other unknown heuristics. To stop the tests from flaking
disable popup blocking in general as this also allows a Developer to now
run `TestFiles.testDownload` as a separate test without getting
window.open blocked.
  • Loading branch information
jelly authored and martinpitt committed May 2, 2024
1 parent 77fe203 commit 6a22cba
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions test/common/cdp.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,8 @@ def cmd(
"--disable-namespace-sandbox", "--disable-seccomp-filter-sandbox",
"--disable-sandbox-denial-logging", "--disable-pushstate-throttle",
"--font-render-hinting=none",
# HACK: For Cockpit-Files downloading uses `window.open` which is sometimes allowed depending on unpredictable and unknown heuristics
"--disable-popup-blocking",
"--v=0", f"--remote-debugging-port={cdp_port}", "about:blank"]


Expand Down

0 comments on commit 6a22cba

Please sign in to comment.