Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: random ids for ui elements made in functions #1397

Closed
wants to merge 1 commit into from

Conversation

akshayka
Copy link
Contributor

RPC triggered creation of a UI element (altair_chart), which then incorrectly evicted an existing UI element from the registry.

RPC triggered creation of a UI element (`altair_chart`), which then
incorrectly evicted an existing UI element from the registry.
@akshayka akshayka requested a review from mscolnick May 16, 2024 22:25
Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 10:28pm
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 10:28pm

@akshayka
Copy link
Contributor Author

@mscolnick if this looks good to you, feel free to merge it into your branch. I noticed a unit test is failing, but it at least works in the smoke test for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants