required_options not updating correctly

[adamzero1]

Description (*)

When a product no longer has a required option this isn't reflected in the DB / frontend.

Related Pull Requests

N/A

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

1. Create a product, with custom options.
2. Make one or more of the options required.
3. Save the product.
4. run select * from catalog_product_entity where entity_id = ENTITY_ID; , validate required_options == 1
5. Make all the custom options not required.
6. Save the product
7. run select * from catalog_product_entity where entity_id = ENTITY_ID; again.
   IF BROKEN: required_options will still be 1
   IF FIXED: required_options will be 0

Questions or comments

Haven't tested this via the API only via the MAP. Have validated that when the product doesn't have any required custom options required_options isn't passed in the payload. (So it's not the UI that's broken)

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] required_options not updating correctly #38720: required_options not updating correctly

[m2-assistant]

Hi @adamzero1. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[engcom-Hotel]

@magento create issue

[adamzero1]

@magento run all tests

[adamzero1]

@magento run all tests