Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax warnings are fixed. #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

CYB3RMX
Copy link

@CYB3RMX CYB3RMX commented Nov 16, 2021

No description provided.

Copy link

@TheOnlyWayUp TheOnlyWayUp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good overall.

@@ -177,9 +177,9 @@ def check_for_wildcard(target):
answer = resolver.query('*.' + target)
#If found, ask user if continue as long until valid answer
choice = ''
while choice is not 'y' and choice is not 'n':
while choice != 'y' and choice != 'n':

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be changed to

while choice not in ['y', 'n']:

As to retain the readability of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants