Added timeout feature for requests. #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the sites I was testing was taking too much time by CloudFail. I traced out the culprit which was the Exception thrown:
which occurs due to default timeout behavior used in requests. So, the process would be stuck on a particular subdomain request for a long time then resume after the exception is thrown.
This PR adds an optional timeout argument chosen by the user and also a default timeout of 5 sec if not given.
Hence, In this way CloudFail won't be stuck on any subdomain and also users will have the option to alter the timeout rather than the rigid hardcoded value.
Also, this makes the runtime of CloudFail to be near deterministic if everything goes right.