Negated enable for multiplexer #1844
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of adding a new INVERT_ENABLE to the multiplexer and PlexersLibrary, we add a new attribute to the PlexersLibrary named ENABLE_TYPE. This attribute is intended to replace the enable attribute for plexer components that support inverted enable. Thus, the enable type attribute clashes in ID with the enable attribute; they are not intended to be used together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an in-progress PR, consisting of an implementation for negated enables for the multiplexer, and eventually for the demultiplexer as well.
As of now, the feature modifies the enable attribute for the multiplexer to add an invert option, which inverts the input for the enable in the component, as well as adding the little indication circle. This new invert option for the enable attribute takes the value id of 'inverted' in the XML.
So, are the designs for the invert enable OK? If that's the case, I will then work on the demultiplexer as well.